Bug #35361

Localize action should keep type

Added by Francois Suter almost 9 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Should have
Category:
DataHandler aka TCEmain
Target version:
Start date:
2012-03-29
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.7
PHP Version:
5.3
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

When the TCEmain command "localize" is used on a table that has a type attribute, this type is not copied automatically. Only the localization parents are set (and any text or input-type fields which have a "l10n_mode = prefixLangTitle" property defined).

This means that a localized record will not have - by default - the same type as its default language parent. This seems definitely wrong.

My use case: I use the extension l10nmgr, which relies on the "localize" command to create newly translated items. In the case of pages, the doktype is not carried over from the default language, so any special kind of page (like shortcuts) are created as standard pages when translated.

One could argue that this is a l10nmgr bug (after all it handles types properly when using same-table translations, which is the most common way), but I think it makes a lot of sense for the Core to carry over the type when localizing any record with such a property.

Test scenario (requires l10nmgr): create a new page and make it of type shortcut. Export it for translation and import if again. Before the patch, the pages_language_overlay record is created of type "Standard". After the patch it has type "Shortcut" like its parent.

#1

Updated by Gerrit Code Review almost 9 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10082

#2

Updated by Gerrit Code Review almost 9 years ago

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/10701

#3

Updated by Gerrit Code Review almost 9 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/10703

#4

Updated by Gerrit Code Review almost 9 years ago

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/10705

#5

Updated by Francois Suter almost 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#6

Updated by Riccardo De Contardi over 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF