Project

General

Profile

Actions
Copy link

Task #35440

closed

Remove Code Duplication in tslib_content_Media

Added by Steffen Ritter about 12 years ago. Updated almost 12 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Steffen Ritter
Category:
Frontend
Target version:
4.7.0-RC1
Start date:
2012-03-31
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.7
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

tslib_content_media has much code duplication for retrieving data from TS and overlaying it with flexForm values, as well as resolving the correct path/url for each file. Both are extracted to external functions and called at all places.

As a step before reintegrating original flvplayer for playing youtube and other external media again, the class should be cleaned up for better experience.

Actions
Copy link
 #1

Updated by Gerrit Code Review about 12 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/10108

Actions
Copy link
 #2

Updated by Gerrit Code Review about 12 years ago

Patch set 2 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/10108

Actions
Copy link
 #3

Updated by Gerrit Code Review about 12 years ago

Patch set 3 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/10108

Actions
Copy link
 #4

Updated by Gerrit Code Review about 12 years ago

Patch set 4 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/10108

Actions
Copy link
 #5

Updated by Gerrit Code Review about 12 years ago

Patch set 5 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/10108

Actions
Copy link
 #6

Updated by Gerrit Code Review about 12 years ago

Patch set 6 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/10108

Actions
Copy link
 #7

Updated by Gerrit Code Review about 12 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10219

Actions
Copy link
 #8

Updated by Steffen Ritter about 12 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #9

Updated by Gerrit Code Review about 12 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10293

Actions
Copy link
 #10

Updated by Wouter Wolters almost 12 years ago

This one is resolved but accidently opened through another change in Gerrit that doesn't exist anymore.

Actions
Copy link
 #11

Updated by Ernesto Baschny almost 12 years ago

  • Status changed from Under Review to Closed
Actions
Copy link

Also available in: Atom PDF