Project

General

Profile

Actions

Bug #36154

closed

Description of pidSelect in class.db_list.inc is misleading

Added by Jo Hasenau over 12 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Documentation
Target version:
Start date:
2012-04-16
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
5.3
Tags:
Complexity:
no-brainer
Is Regression:
Sprint Focus:

Description

The description says "list of IDs", where it should be "query part for a list of IDs or a single ID"

If you don't dive into the code but just check the description while using the variable i.e. within a hooked method, this will lead to an error or unwanted behaviour.

Setting it to a single integer will just remove pid from the query giving you a result from all possible pages.
Setting it to a list of integers will trow an error message.

In our case it was the cause for a bug in grid elements, showing child elements still in their containers even though they where moved to another page.

Found it in 4.5.x, but still there in current master

Actions #1

Updated by Gerrit Code Review over 12 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10549

Actions #2

Updated by Gerrit Code Review over 12 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10549

Actions #3

Updated by Gerrit Code Review over 12 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10549

Actions #4

Updated by Gerrit Code Review over 12 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10549

Actions #5

Updated by Jo Hasenau over 12 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Riccardo De Contardi about 7 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF