Bug #36937
closedCustom Swift_Transport is impossible due to wrong variable
100%
Description
Because of a wrong variable it is impossible to implement a custom Swift_Transport
Imagine you want to do an own Swift_Transport implementation you add
$GLOBALS['TYPO3_CONF_VARS']['MAIL']['transport'] = 'Tx_Fo_Bar';
but because of the constructor being called without any special name, it is tried to look the default one up in the TYPO3_CONF_VARS as stated in the comment
---
Swift_Transport optionally pass a transport to the constructor. By default the configured transport from $TYPO3_CONF_VARS is used
----
current code
$customTransport = t3lib_div::makeInstance($mailSettings['transport'], $mailSettings);
if ($this->transport instanceof Swift_Transport) {
$this->transport = $customTransport;
} else {
throw new RuntimeException(
$mailSettings['transport'] . ' is not an implementation of Swift_Transport,
but must implement that interface to be used as a mail transport.',
1323006478
);
}
therefore $this->transport will never be an instanceof Swift_Transport as it will be always empty at that place. needs to be of course $customTransport
Updated by Gerrit Code Review over 12 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11062
Updated by Georg Ringer over 12 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 88d95069e8994caee7356a612619a6be4ca98d82.
Updated by Gerrit Code Review over 12 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/11064
Updated by Georg Ringer over 12 years ago
- Status changed from Under Review to Resolved
Applied in changeset 4b36200e25f0a6f53db9ef2bd8065378757941ba.
Updated by Gerrit Code Review over 12 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/13133
Updated by Georg Ringer over 12 years ago
- Status changed from Under Review to Resolved
Updated by Riccardo De Contardi about 7 years ago
- Status changed from Resolved to Closed