Task #38604

Code Cleanup: Always return a boolean in t3lib_div::validPathStr

Added by Andy Grunwald about 10 years ago. Updated almost 10 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Code Cleanup
Target version:
Start date:
2012-07-03
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.0
PHP Version:
Tags:
Complexity:
no-brainer
Sprint Focus:

Description

In t3lib_div::validPathStr() a boolean (TRUE) is returned, if this is a valid path string.
If it is NOT a valid path string, then nothing will be returned.
In the doc comment, there is a return type "boolean" mentioned.

Just return a boolean, if it is not a valid path string.


Related issues

Related to TYPO3 Core - Bug #38613: Fix UnitTests for t3lib_div::validPathStrClosedAndy Grunwald2012-07-03

Actions
#1

Updated by Gerrit Code Review about 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12549

#2

Updated by Andy Grunwald about 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#3

Updated by Gerrit Code Review about 10 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/12667

#4

Updated by Gerrit Code Review about 10 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/12668

#5

Updated by Gerrit Code Review about 10 years ago

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/12669

#6

Updated by Gerrit Code Review about 10 years ago

Patch set 2 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/12667

#7

Updated by Gerrit Code Review about 10 years ago

Patch set 3 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/12667

#8

Updated by Gerrit Code Review about 10 years ago

Patch set 2 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/12668

#9

Updated by Gerrit Code Review about 10 years ago

Patch set 2 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/12669

#10

Updated by Andy Grunwald about 10 years ago

  • Status changed from Under Review to Resolved
#11

Updated by Gerrit Code Review about 10 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/13205

#12

Updated by Gerrit Code Review about 10 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/13312

#13

Updated by Georg Ringer almost 10 years ago

this is IMO fully merged, right?

#14

Updated by Wouter Wolters almost 10 years ago

Yes, this can be closed. The http://review.typo3.org/13205 and http://review.typo3.org/13312 does not exist

#15

Updated by Georg Ringer almost 10 years ago

  • Status changed from Under Review to Closed

Also available in: Atom PDF