Task #38604
closedCode Cleanup: Always return a boolean in t3lib_div::validPathStr
100%
Description
In t3lib_div::validPathStr() a boolean (TRUE) is returned, if this is a valid path string.
If it is NOT a valid path string, then nothing will be returned.
In the doc comment, there is a return type "boolean" mentioned.
Just return a boolean, if it is not a valid path string.
Updated by Gerrit Code Review about 12 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12549
Updated by Andy Grunwald about 12 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 23cee13609c8011f81429468fda485d94a8517b8.
Updated by Gerrit Code Review about 12 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/12667
Updated by Gerrit Code Review about 12 years ago
Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/12668
Updated by Gerrit Code Review about 12 years ago
Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/12669
Updated by Gerrit Code Review about 12 years ago
Patch set 2 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/12667
Updated by Gerrit Code Review about 12 years ago
Patch set 3 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/12667
Updated by Gerrit Code Review about 12 years ago
Patch set 2 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/12668
Updated by Gerrit Code Review about 12 years ago
Patch set 2 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/12669
Updated by Andy Grunwald about 12 years ago
- Status changed from Under Review to Resolved
Applied in changeset e0049f63565f3b0475df5ef5d25679d76b8da8bf.
Updated by Gerrit Code Review about 12 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/13205
Updated by Gerrit Code Review about 12 years ago
Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/13312
Updated by Wouter Wolters about 12 years ago
Yes, this can be closed. The http://review.typo3.org/13205 and http://review.typo3.org/13312 does not exist
Updated by Georg Ringer almost 12 years ago
- Status changed from Under Review to Closed