Project

General

Profile

Actions
Copy link

Task #38604

closed

Code Cleanup: Always return a boolean in t3lib_div::validPathStr

Added by Andy Grunwald over 12 years ago. Updated about 12 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Andy Grunwald
Category:
Code Cleanup
Target version:
6.0.0
Start date:
2012-07-03
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.0
PHP Version:
Tags:
Complexity:
no-brainer
Sprint Focus:

Description

In t3lib_div::validPathStr() a boolean (TRUE) is returned, if this is a valid path string.
If it is NOT a valid path string, then nothing will be returned.
In the doc comment, there is a return type "boolean" mentioned.

Just return a boolean, if it is not a valid path string.

Related issues 1 (0 open — 1 closed)

Related to TYPO3 Core - Bug #38613: Fix UnitTests for t3lib_div::validPathStrClosedAndy Grunwald2012-07-03

Actions
Actions
Copy link
 #1

Updated by Gerrit Code Review over 12 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12549

Actions
Copy link
 #2

Updated by Andy Grunwald over 12 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #3

Updated by Gerrit Code Review over 12 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/12667

Actions
Copy link
 #4

Updated by Gerrit Code Review over 12 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/12668

Actions
Copy link
 #5

Updated by Gerrit Code Review over 12 years ago

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/12669

Actions
Copy link
 #6

Updated by Gerrit Code Review over 12 years ago

Patch set 2 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/12667

Actions
Copy link
 #7

Updated by Gerrit Code Review over 12 years ago

Patch set 3 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/12667

Actions
Copy link
 #8

Updated by Gerrit Code Review over 12 years ago

Patch set 2 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/12668

Actions
Copy link
 #9

Updated by Gerrit Code Review over 12 years ago

Patch set 2 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/12669

Actions
Copy link
 #10

Updated by Andy Grunwald over 12 years ago

  • Status changed from Under Review to Resolved
Actions
Copy link
 #11

Updated by Gerrit Code Review over 12 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/13205

Actions
Copy link
 #12

Updated by Gerrit Code Review over 12 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/13312

Actions
Copy link
 #13

Updated by Georg Ringer over 12 years ago

this is IMO fully merged, right?

Actions
Copy link
 #14

Updated by Wouter Wolters over 12 years ago

Yes, this can be closed. The http://review.typo3.org/13205 and http://review.typo3.org/13312 does not exist

Actions
Copy link
 #15

Updated by Georg Ringer about 12 years ago

  • Status changed from Under Review to Closed
Actions
Copy link

Also available in: Atom PDF