Bug #39048: TCEforms inline renders broken fields - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #39048

closed

TCEforms inline renders broken fields

Added by Alexander Jahn over 12 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

FormEngine aka TCEforms

Target version:

Start date:

2012-07-18

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

4.7

PHP Version:

Tags:

Complexity:

no-brainer

Is Regression:

Sprint Focus:

Description

When loading tt_content as an inline record WITHOUT using AJAX, some additional broken fields are rendered.

Specifically these are

<input type="checkbox" name="data[tt_content][10605][hidden]_0" value="1"/>
<input type="input" name="data[tt_content][10605][hidden]" value="0"/>

These Fields are already rendered where they should be.

These fields are only used for tracking a record's hidden status if the record is rendered by an AJAX call and is not expanded.
If the record is loaded directly, it might not be expanded but is still completely rendered in the background making these fields unnecessary.

My patch includes an additional check whether the record is rendered by an AJAX call, thus fixing the problem.

Files

Download all files

broken_field.JPG (61.4 KB) broken_field.JPG	Screenshot	Alexander Jahn, 2012-07-18 09:36
class.t3lib_tceforms_inline.php.patch (1.22 KB) class.t3lib_tceforms_inline.php.patch	Patch for 4.7.2	Alexander Jahn, 2012-07-18 09:36

Actions

Copy link

Updated by Gerrit Code Review over 12 years ago

Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12904

Actions

Copy link

Updated by Gerrit Code Review over 11 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/12904

Actions

Copy link

Updated by Gerrit Code Review almost 11 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/12904

Actions

Copy link

Updated by Alexander Opitz almost 11 years ago

Target version deleted (~~4.7.3~~)
Is Regression set to No

Hi Alexander,

can you provide a step for step testing and maybe an example extension which shows this issue? So we can test the patches.

Actions

Copy link

Updated by Alexander Jahn almost 11 years ago

Hi Alexander,

testing is rather easy. All you need is an extension that uses inline records (ie news, blog_example).

Then change the following in the extension's TCA (eg field content_elements in news):

$TCA['tx_news_domain_model_news']['columns']['content_elements']['config']['appearance']['ajaxLoad'] = false;

Then open a news record and expand the content element.
you will see the additional broken field

Actions

Copy link

Updated by Gerrit Code Review almost 11 years ago

Patch set 1 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27280

Actions

Copy link