Project

General

Profile

Actions

Bug #39075

closed

CSC ignores removeDefaultCss with accessibilityMode

Added by Julian Wachholz over 12 years ago. Updated about 11 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Content Rendering
Target version:
-
Start date:
2012-07-19
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.7
PHP Version:
Tags:
Complexity:
no-brainer
Is Regression:
Sprint Focus:

Description

In class tx_cssstyledcontent_pi1 around line 617:

if ($accessibilityMode) {
   // ..
   $this->addPageStyle('.csc-textpic-intext-right-nowrap .csc-textpic-text', 'margin-right: ' . $noWrapMargin . 'px;');
   // ..
}

This should respect the setting of config.removeDefaultCss and not add any styles at all if it's set to 1.

Actions #1

Updated by Gerrit Code Review over 11 years ago

  • Status changed from New to Under Review

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/19912

Actions #2

Updated by Gerrit Code Review over 11 years ago

Patch set 2 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/19912

Actions #3

Updated by Chris topher over 11 years ago

Julian Wachholz wrote:

$this->addPageStyle should respect the setting of config.removeDefaultCss and not add any styles at all if it's set to 1.

For TYPO3 6.1 the new property config.removePageCss has been added, which allows to remove both _CSS_DEFAULT_STYLE and _CSS_PAGE_STYLE separately. See the description of removeDefaultCss and removePageCss here.

I think this solves the problem, which Julian reported here.

Actions #4

Updated by Dan Kleine (Untenzu) over 11 years ago

✔ This issue is solved with using »config.removePageCss = 1«.

Actions #5

Updated by Chris topher about 11 years ago

  • Status changed from Under Review to Closed
Actions

Also available in: Atom PDF