Bug #39103
closedFix Clear Language Cache Configuration
100%
Description
Hi,
there are several issues with the configuration of clearing the language cache.
Wrong option naming in UserTSconfig¶
In "class.tx_lang_clearcachemenu.php" the UserTS option "options.clearCache.clearRTECache" is taken into account. This should be renamed to "options.clearCache.clearLangCache".
"Clear cache" Icon next to the Username (Thunderstorm Icon) is not shown, if clearLangCache (aka clearRTECache) is the only option to delete a cache.¶
I will dig into this. I assume that &$cacheActions are not initialized.
Configuration is inconsistent.¶
IMO the configuration of clearing the language cache is inconsistent to the rest of cache clearing. Why?
1) Clearing the the language cache is excluded from "Clear all caches" if $GLOBALS['TYPO3_CONF_VARS']['SYS']['lang']['cache']['clear_menu'] is set2) In order to enable clearing the language cache for normal editors, one has to set two values
- localconf.php: $GLOBALS['TYPO3_CONF_VARS']['SYS']['lang']['cache']['clear_menu'] = TRUE
- UserTSConfig: options.clearCache.clearLangCache
I am in favor of dropping $GLOBALS['TYPO3_CONF_VARS']['SYS']['lang']['cache']['clear_menu'].
1) Language Cache Clearing should be included in "Clear all caches"
2) Other clear cache actions (pages / all) do not require two config options set.
I will come up with a patch
Bests
Marcus
Files
Updated by Marcus Schwemer over 12 years ago
- File master_39103_v01.diff master_39103_v01.diff added
- % Done changed from 0 to 100
Hi,
here is the patch. :-)
All three mentioned issues work now.
Bests
Marcus
Updated by Gerrit Code Review over 12 years ago
- Status changed from New to Under Review
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12912
Updated by Gerrit Code Review over 12 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12912
Updated by Gerrit Code Review over 12 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12912
Updated by Gerrit Code Review over 12 years ago
Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12912
Updated by Gerrit Code Review almost 12 years ago
Patch set 6 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/12912
Updated by Gerrit Code Review almost 12 years ago
Patch set 7 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/12912
Updated by Gerrit Code Review over 11 years ago
Patch set 8 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/12912
Updated by Gerrit Code Review over 11 years ago
Patch set 9 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/12912
Updated by Marcus Schwemer over 11 years ago
- Status changed from Under Review to Resolved
Applied in changeset b1caf3b17746d90d8f51304aacd35dadabff4764.