Bug #40540
closed
LogLevelTest dataProvider not used
100%
Description
isValidLevelThrowsExceptionOnInvalidLevelIfAskedToDoSo() test throwed a
warning that required input parameter $inputValue was not used. This was
because of a typo @dataprovider -> @dataProvider, so the data provider
was not used at all. Fixing this, one of the tests with the
object \stdClass failed.
This turned out to be an error in the thrown exception in validateLevel
because the exception is not thrown, if the exception message is
compiled from a string and an object. Therefore, the parameter $level
is now left out in method validateLevel().
As additional cleanup, the MathUtilityTest is moved from t3lib to core
extension, and the rootline test and fixture names are adapted.
Updated by Gerrit Code Review over 11 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/14295
Updated by Christian Kuhn over 11 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 93e12ed884a20f82bcc31ffb9bfa6ebd3ba4beab.
Updated by Riccardo De Contardi over 6 years ago
- Status changed from Resolved to Closed