Bug #41130

Parameter $alternativeUrl not obeyed in t3lib_BEfunc::viewOnClick

Added by Kasper Ligaard over 8 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
-
Target version:
-
Start date:
2012-09-20
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

In the method viewOnClick the parameter $alternativeUrl is documented like this: "$alternativeUrl is an alternative URL which - if set - will make all other parameters ignored: The function will just return the window.open command wrapped around this URL! The hook will allow modification, though."

But that is not obeyed anymore. The semantics of the method was inadvertently changed when a hook was added, see bug #22157. Rectifying the semantics while keeping the hook is luckily no problem.

The change needs to be done in TYPO3 4.4, 4.5, 4.6, 4.7 and 6.0.

NB: This is my first attempt at submitting to core after the change last year, so bear with me and guide me, if I do something the wrong way. I will start with (trying) to upload a patch for review in Gerrit in review.typo3.org.


Related issues

Related to TYPO3 Core - Bug #41165: Parameter $alternativeUrl not obeyed in t3lib_BEfunc::viewOnClickClosed2012-09-20

Actions
#1

Updated by Gerrit Code Review over 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/14778

#2

Updated by Kasper Ligaard over 8 years ago

This issue can be closed. I have made a patch against master-branch (TYPO3 6.0) instead. See issue #41165

Gerrit Code Review wrote:

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/14778

#3

Updated by Alexander Opitz over 7 years ago

  • Status changed from Under Review to Closed

Also available in: Atom PDF