Bug #41608

Page Information shows incorrect number of Total hits

Added by Andrew Moore over 8 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Target version:
-
Start date:
2012-10-05
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.7
PHP Version:
5.3
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

Going into the Page Information section of the Page module on all pages gives the incorrect number of page hits. Due to a bug in the code it is actually displaying a timestamp instead!

Note that page hit information will only appear if the sys_stat extension is installed.

This can easily be fixed by changing line 2471 (in version 4.7.4) of typo3\sysext\cms\layout\class.tx_cms_layout.php from this:

$lines[] = array($GLOBALS['LANG']->getLL('pI_hitsTotal') . ':', $rrow20);

to this:

$lines[] = array($GLOBALS['LANG']->getLL('pI_hitsTotal') . ':', $count);

Looks like someone just made a small mistake when reworking the code at some point. Anyway, easy fix!

#1

Updated by Steffen Gebert over 8 years ago

  • Status changed from New to Accepted
  • Priority changed from Must have to Should have
  • Target version deleted (4.7.5)

Thanks for your report, Andrew.

It looks pretty straight-forward what you report. You've already half of the work done - could you please push the change into the review workflow? See http://wiki.typo3.org/Contribution_Walkthrough_Tutorials

Please don't try to fix this in master branch (which will be 6.0 later), as this feature has been removed there. So please push directly to branch TYPO3_4-7.

If you have any questions or problems, just ask here or in the mailing lists!

Thanks!
Steffen

#2

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/16378

#3

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/16378

#4

Updated by Gerrit Code Review over 8 years ago

Patch set 3 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/16378

#5

Updated by old_snowman61 over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#6

Updated by Ernesto Baschny over 8 years ago

  • Status changed from Resolved to Under Review

This same fix also applies to TYPO3 4.6 and 4.5. Commit message should carry a "Releases" line displaying all relevant branches, so that we don't forget to backport the fix to previous releases. See http://www.typo3-anbieter.de/typo3-merges/core.html

I'll take care of the backports. Thanks!

#7

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/16879

#8

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/16880

#9

Updated by Ernesto Baschny over 8 years ago

  • Status changed from Under Review to Resolved
#10

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF