Project

General

Profile

Actions
Copy link

Bug #41641

closed

t3lib_db StripOrderBy, stripGroupBy fails if clause is misspelled or appears twice.

Added by Laurent Cherpit about 12 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Database API (Doctrine DBAL)
Target version:
-
Start date:
2012-10-06
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.7
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If ORDER BY or GROUP BY clauses are misspelled or appear twice in the given string. This fails.

Change the expression to be more tolerant and capable to clean, strip the related clauses efficiently.
It could allows to strip that kind of string:

ORDER BY name, tstamp DESC
ORDER BY  name, tstamp DESC
ORDERBY name, tstamp DESC
ORDER BY ORDER BY name, tstamp DESC
ORDERBY ORDER BY  name, tstamp DESC
ORDER BYORDERBY name, tstamp DESC
ORDERBYORDERBY name, tstamp DESC
ORDERBYORDERBYname, tstamp DESC
ORDERBYORDERBY ORDER BY name, tstamp DESC
etc..
Actions
Copy link
 #1

Updated by Gerrit Code Review about 12 years ago

  • Status changed from New to Under Review

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/15370

Actions
Copy link
 #2

Updated by Gerrit Code Review about 12 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/15371

Actions
Copy link
 #3

Updated by Gerrit Code Review about 12 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/15371

Actions
Copy link
 #4

Updated by Gerrit Code Review about 12 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/15371

Actions
Copy link
 #5

Updated by Gerrit Code Review about 12 years ago

Patch set 2 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/15370

Actions
Copy link
 #6

Updated by Gerrit Code Review about 12 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/15371

Actions
Copy link
 #7

Updated by Laurent Cherpit about 12 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #8

Updated by Gerrit Code Review about 12 years ago

  • Status changed from Resolved to Under Review

Patch set 3 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/15370

Actions
Copy link
 #9

Updated by Gerrit Code Review about 12 years ago

Patch set 4 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/15370

Actions
Copy link
 #10

Updated by Gerrit Code Review almost 12 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at https://review.typo3.org/17629

Actions
Copy link
 #11

Updated by Gerrit Code Review almost 12 years ago

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at https://review.typo3.org/17630

Actions
Copy link
 #12

Updated by Gerrit Code Review over 11 years ago

Patch set 5 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/15370

Actions
Copy link
 #13

Updated by Gerrit Code Review over 11 years ago

Patch set 2 for branch TYPO3_4-5 has been pushed to the review server.
It is available at https://review.typo3.org/17630

Actions
Copy link
 #14

Updated by Laurent Cherpit over 11 years ago

  • Status changed from Under Review to Resolved
Actions
Copy link
 #15

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF