Project

General

Profile

Actions

Bug #42106

closed

swiftmaileradapter should ignore empty headers

Added by Stefan Neufeind about 12 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Category:
Backend API
Target version:
-
Start date:
2012-10-18
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

There are cases when for example Direct Mail (by error) sends an empty header, in this case "Reply-To:". That leads to an error like described in #27633 later with swiftmailer (Address in mailbox given [@localhost] does not comply with RFC 2822, 3.6.2).

In t3lib/mail/class.t3lib_mail_swiftmaileradapter.php inside setHeader() the headers are transfered over. Executing the line

$addressList = $this->parseAddresses($headerValue);

on the empty value leads to transfer the address to "@localhost" here.

Suggestion: trim $headerValue and check it is not empty before transfering it.

Actions #1

Updated by Stefan Neufeind about 12 years ago

I'm still looking into why Direct Mail generates an empty Reply-To-header anyhow. But, if by error, such a value slips in we could ignore it in the adapter.

Actions #2

Updated by Stefan Neufeind almost 12 years ago

  • Assignee set to Stefan Neufeind

Already under review at: https://review.typo3.org/15779

Actions #3

Updated by Gerrit Code Review over 11 years ago

  • Status changed from New to Under Review

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/15779

Actions #4

Updated by Gerrit Code Review over 11 years ago

Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/19685

Actions #5

Updated by Gerrit Code Review over 11 years ago

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/19686

Actions #6

Updated by Gerrit Code Review over 11 years ago

Patch set 2 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/19686

Actions #7

Updated by Gerrit Code Review over 11 years ago

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at https://review.typo3.org/19687

Actions #8

Updated by Stefan Neufeind over 11 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #9

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF