Project

General

Profile

Actions

Task #42639

closed

Speed up salted password unit test

Added by Christian Kuhn about 12 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Tests
Target version:
Start date:
2012-11-02
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.0
PHP Version:
5.3
Tags:
Complexity:
medium
Sprint Focus:

Description

The patch removes tests in blowfish and phpass salting classes that
test maximum iteration count returns a valid salt. The underlying
salt code is slow by design, so the tests also take ages. The
functionality itself is already covered by the minimum salt count
test as well, thus - after speaking with Marcus Krause - we decided
to remove them without substitution to reduce the unit test suit
runtime.

Actions #1

Updated by Gerrit Code Review about 12 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/16141

Actions #2

Updated by Christian Kuhn about 12 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #3

Updated by Riccardo De Contardi about 7 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF