Project

General

Profile

Actions

Task #4270

closed

Change the current message implementation to use the core's t3lib_FlashMessages

Added by Ingo Renner over 15 years ago. Updated almost 11 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
scheduler
Target version:
-
Start date:
2009-08-19
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Change the current message implementation to use the core's t3lib_FlashMessages

Actions #1

Updated by Ingo Renner about 15 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Applied in changeset r1132.

Actions #2

Updated by Francois Suter about 15 years ago

Tested and reviewed. Thanks for the work!

One thing though: there's a change that's unrelated to the patch. Close to line 1110 of mod1/index.php there's the following line:

$parts = t3lib_div::trimExplode(' ', $this->submittedData['frequency'], 1);

You removed the "1" flag. As far as I can tell from looking at what the "trim" function does, this change has no impact, but I would have liked this change not to have been hidden among another patch.

Actions #3

Updated by Francois Suter about 15 years ago

As a follow-up, I cleaned up code, CSS and images related to status messages that were still in the scheduler. In r1141.

Actions #4

Updated by Francois Suter about 15 years ago

And a follow-up to my cleanup: changed check screen to use flash message styles. In r1146

Actions #5

Updated by Ingo Renner about 15 years ago

Francois Suter wrote:

$parts = t3lib_div::trimExplode(' ', $this->submittedData['frequency'], 1);

You removed the "1" flag. As far as I can tell from looking at what the "trim" function does, this change has no impact, but I would have liked this change not to have been hidden among another patch.

Don't remember why I did that, must have slipped through, maybe an unintended change when removing the 1 values for messages.

Actions #6

Updated by Ingo Renner about 15 years ago

Francois Suter wrote:

As a follow-up, I cleaned up code, CSS and images related to status messages that were still in the scheduler. In r1141.

true, somehow forgot about that. thanks!

Actions #7

Updated by Francois Suter over 12 years ago

  • Status changed from Resolved to Closed
Actions #8

Updated by Michael Stucki almost 11 years ago

  • Category set to scheduler
Actions #9

Updated by Michael Stucki almost 11 years ago

  • Project changed from 739 to TYPO3 Core
  • Category changed from scheduler to scheduler
Actions

Also available in: Atom PDF