Bug #43101

File relations are broken for import. in IMAGE cObject

Added by Nicole Cordes over 8 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
File Abstraction Layer (FAL)
Target version:
Start date:
2012-11-19
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.0
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

While trying to show an image link in pages/media I recognised FAL can't handle relations in IMAGE / file.import

I debugged it and found out, that in the field pages/media the uid of the reference relation is stored while FAL tries to load the image with that uid (ContentObjectRenderer::getImgResource)

Line 5041 should maybe turned into
$fileObject = \TYPO3\CMS\Core\Resource\ResourceFactory::getInstance()->getFileReferenceObject($file)->getOriginalFile();

IMHO this drops the functionality to insert files without any relation. So maybe it would be better to introduce a new TS property (isReference = 1) and handle that correctly.


Related issues

Related to TYPO3 Core - Bug #43984: Add missing stdWrap to treatIdAsReferenceClosed2012-12-14

Actions
#1

Updated by Andreas Wolf over 8 years ago

  • Category set to File Abstraction Layer (FAL)
  • Status changed from New to Accepted
#2

Updated by Andreas Wolf over 8 years ago

  • Subject changed from FAL doesn't handle .import functionality to File relations are broken for import. in IMAGE cObject
#3

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/16584

#4

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/16584

#5

Updated by Gerrit Code Review over 8 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/16584

#6

Updated by Gerrit Code Review over 8 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/16584

#7

Updated by Gerrit Code Review over 8 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/16584

#8

Updated by Gerrit Code Review over 8 years ago

Patch set 6 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/16584

#9

Updated by Gerrit Code Review over 8 years ago

Patch set 7 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/16584

#10

Updated by Nicole Cordes over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#11

Updated by Riccardo De Contardi over 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF