Bug #43331

"Strict standards: Declaration of "CompatbilityClassLoaderPhpBelow50307" bug

Added by Ernesto Baschny almost 7 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
-
Target version:
Start date:
2012-11-27
Due date:
% Done:

100%

TYPO3 Version:
6.0
PHP Version:
5.3
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

On PHP < 5.3 I get this warning on top of the login screen (and also in the whole backend, making it completely unusable):

Strict standards: Declaration of TYPO3\CMS\Core\Compatibility\CompatbilityClassLoaderPhpBelow50307::requireClassFileOnce() should be compatible with that of TYPO3\CMS\Core\Core\ClassLoader::requireClassFileOnce() in /.../typo3_src/typo3/sysext/core/Classes/Core/SystemEnvironmentBuilder.php on line 239

Acording to git bisect this got broken with change #43285.

Indeed the declaration of the methods differ:

class ClassLoader {
...
        static protected function requireClassFileOnce($classPath) {
...
class CompatbilityClassLoaderPhpBelow50307 extends \TYPO3\CMS\Core\Core\ClassLoader {
...
        static public function requireClassFileOnce($classPath, $className) {
...

And by the way, the classname CompatbilityClassLoaderPhpBelow50307 is misspelled (misses an "i" in Compat*i*bility).


Related issues

Related to TYPO3 Core - Task #43285: Protect bootstrap methods Closed 2012-11-25

Associated revisions

Revision 5961bc5c (diff)
Added by Christian Kuhn almost 7 years ago

[BUGFIX] PHP strict warning in class loader

The compatibility class loader overwrites method requireClassFileOnce
and adds a parameter. This triggers a PHP strict warning.

Change-Id: I6adedd1c6586e84f35d83433cba14dd3201bfe0c
Resolves: #43331
Releases: 6.0
Reviewed-on: http://review.typo3.org/16783
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

History

#1 Updated by Christian Kuhn almost 7 years ago

  • PHP Version changed from 5.2 to 5.3
  • Complexity set to easy

confirmed both the typo and the method signature issue.

#2 Updated by Gerrit Code Review almost 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/16783

#3 Updated by Christian Kuhn almost 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Riccardo De Contardi about 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF