Bug #43459
closed
duplicate code in typo3.pageModule.js
100%
Description
Just completely duplicated.
Updated by Falk Kühnel almost 12 years ago
added a pullrequest to github:
https://github.com/typo3/TYPO3v4-Core/pull/15
Updated by Ernesto Baschny almost 12 years ago
- Category set to Backend API
- Target version deleted (
6.0.1)
Thanks for contributing, Falk!
Please note that the github repository is not our main repository but only a "read-only mirror". So pull requests on github won't be merged anyway.
The proper way to submit an enhancement suggestion would be via our review system and main git repository (git.typo3.org and review.typo3.org).
Please refer to this walkthrough for further information on the step by step tutorial:
http://wiki.typo3.org/Contribution_Walkthrough_with_CommandLine
Updated by Falk Kühnel almost 12 years ago
Ernesto Baschny wrote:
Please note that the github repository is not our main repository but only a "read-only mirror". So pull requests on github won't be merged anyway.
Noted and set up everything to commit. Unfortunately, or better fortunately, the issue seems to have been resolved already.
I guess you can close this then.
Updated by Ernesto Baschny almost 12 years ago
- Status changed from New to Accepted
It doesn't seem to be solved yet in the current branches (4.5, 4.6, 4.7, 6.0 and master). So the "problem" still applies to all of them.
So I leave it as an exercise to you to open up a review request for it with the change (in branch "master" for a start). ;)
Updated by Gerrit Code Review almost 12 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/16867
Updated by Falk Kühnel almost 12 years ago
OK, i guess that first one worked.
Gerrit Code Review wrote:
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/16867
Updated by Gerrit Code Review almost 12 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/16867
Updated by Falk Kühnel almost 12 years ago
Actually, i just found out, that this file seems not to be used anymore. at least for 6.0.
There is another file in the js folder, which actually seems to be used.
Updated by Ernesto Baschny almost 12 years ago
Indeed it might really be. It seems that there are two similar files:
- typo3/sysext/cms/layout/js/typo3pageModule.js
- typo3/sysext/cms/layout/res/typo3.pageModule.js
The second one seems to be some very old leftover during the 4.5 development. I was not able to spot the exact revision when this stopped being used.
Updated by Gerrit Code Review almost 12 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/16867
Updated by Gerrit Code Review almost 12 years ago
Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at http://review.typo3.org/16903
Updated by Gerrit Code Review almost 12 years ago
Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/16904
Updated by Gerrit Code Review almost 12 years ago
Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/16905
Updated by Gerrit Code Review almost 12 years ago
Patch set 2 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/16905
Updated by Gerrit Code Review almost 12 years ago
Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/16906
Updated by Gerrit Code Review almost 12 years ago
Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/16907
Updated by Falk Kühnel almost 12 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 1666d38f8785582801adc1ae4499b9acbdc1567e.
Updated by