Bug #43949

Cleanups for the Authentication Classes

Added by Sebastian Michaelsen almost 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2012-12-13
Due date:
% Done:

0%

TYPO3 Version:
6.1
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

For the classes:
\TYPO3\CMS\Core\Authentication\AbstractUserAuthentication
\TYPO3\CMS\Core\Authentication\AbstractUserAuthenticationFrontendUserAuthtenication (did you see the typo in the class name? :/ )
\TYPO3\CMS\Core\Authentication\BackendUserAuthentication
\TYPO3\CMS\Backend\FrontendBackendUserAuthentication

do the following cleanups:
- provide proper phpDoc comments for all properties and methods
- remove a lot of "@todo Define visibility" annotations for properties and methods that already have a visibility definition
- some minor cleanups


Related issues

Related to TYPO3 Core - Bug #43464: FrontendUserAuthtenication is misspelled Closed 2012-11-29

History

#1 Updated by Gerrit Code Review almost 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17148

#2 Updated by Gerrit Code Review almost 7 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17148

#3 Updated by Gerrit Code Review almost 7 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17148

#4 Updated by Gerrit Code Review almost 7 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17148

#5 Updated by Wouter Wolters over 6 years ago

  • Status changed from Under Review to Closed

Abandoned in Gerrit
Author: "@todo Define visilibility" shouldn't be removed and patch can't merge anymore and was too big anyway

Also available in: Atom PDF