Bug #45065

Remove delete button for sys_file

Added by Helmut Hummel over 8 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
-
Start date:
2013-02-01
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.0
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The edit view of file meta data currently has
a delete button, which sets the record of this
file to deleted, but does not delete the file itself.

It might be useful at some point
to use this to implement some recycler
functionality, but currently the FAL layer
has no support for it and a file with a deleted
meta data record is an inconsistent state
which has to be avoided by all means.


Related issues

Related to TYPO3 Core - Bug #44581: Editing file properties and pushing the delete button in docheader leads to exceptionClosed2013-01-16

Actions
#1

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/17916

#2

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17917

#3

Updated by Anonymous over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#4

Updated by Ingo Renner over 8 years ago

  • Category set to File Abstraction Layer (FAL)
  • Status changed from Resolved to Needs Feedback
  • Assignee set to Helmut Hummel

I agree with the problem of the inconsistent state, but wouldn't the correct solution be to hook into TCEmain, monitor sys_file deletes and then also remove the file? Simply merging this one doesn't seem right to me...

#5

Updated by Helmut Hummel over 8 years ago

  • Status changed from Needs Feedback to Resolved
  • Assignee deleted (Helmut Hummel)

Ingo Renner wrote:

I agree with the problem of the inconsistent state, but wouldn't the correct solution be to hook into TCEmain, monitor sys_file deletes and then also remove the file? Simply merging this one doesn't seem right to me...

The whole file/ data handling needs to be re-thought with FAL. There are a still a lot of things to do in this area.
Any help in this area is appreciated. Feel free to work on that.

Hiding the delete button is very effective with minimum amount of impact and effort to avoid accidental removal of the record.

Please open new tickets for further improvements in this area.

#6

Updated by Ingo Renner over 8 years ago

Agreed. I might have a 6.0 project soon, would be happy to help.

#7

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF