Bug #45092
closedAllow disabling the default MediaWizardProvider
0%
Description
At the moment it does not seem possible to disable the default MediaWizardProvider
TYPO3\CMS\Frontend\MediaWizard\MediaWizardProvider
This also makes it impossible to use custom renderers in TYPO3\CMS\Frontend\ContentObject\MediaContentObject
for all URLs that this renderer can handle.
I already tried to extend the MediaWizardProvider with the configuration in
$GLOBALS['TYPO3_CONF_VARS']['SYS']['Objects']['TYPO3\\CMS\\Frontend\\MediaWizard\\MediaWizardProvider']
This does not work because:
- when I put it in the
ext_localconf.php
file of my extension (mediaoembed) the configuration file of the cms extension that registers the MediaWizardProvider gets always loaded before the configuration file of the extension, so it does not know about the overwritten class. - when I put it my global
AdditionalConfiguration.php
the overwritten class configuration gets recognized but the class loader will throw an exception because the mediaoembed extension is not loaded (yet).
As far as I can see, there are several approaches to solve this.
- Do not call
\TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance()
when calling\TYPO3\CMS\Frontend\MediaWizard\MediaWizardProviderManager::registerMediaWizardProvider()
. This is just too early. There needs to be some initialization method in theMediaWizardProviderManager
that gets called one time at the beginning ofgetValidMediaWizardProvider()
. This would make sure that the class overwriting system is fully initialized. - Add a configuration variable for
LocalConfiguration.php
to disable the registration of the defaultMediaWizardProvider
Maybe even both solutions should be implemented.
Do you have any input on this? Otherwise I will start writing a patch.
Would this be a bugfix or a feature?
Updated by Alexander Stehlik over 11 years ago
I just realized, that I can register my own provider that always returns TRUE in canHandle()
. But this does not help.
As soon as a valid media provider was found, the $renderType
gets overwritten and I can't use my own renderer any more :(
Updated by Gerrit Code Review over 11 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17996
Updated by Gerrit Code Review over 11 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17996
Updated by Gerrit Code Review over 11 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17996
Updated by Gerrit Code Review about 11 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17996
Updated by Christian Kuhn about 10 years ago
- Description updated (diff)
- Status changed from Under Review to Closed
- Is Regression set to No
resolved with the related issue.