Bug #45308

uid of processed file is sometimes updated during processing

Added by Andreas Wolf over 8 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
File Abstraction Layer (FAL)
Target version:
Start date:
2013-02-09
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.0
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

After a file is being (re)processed, the information about it is stored in the database again. This is done by the ProcessedFileRepository. The repository gathers information for the update from the processed file.

For files that are not changed (i.e. used as they are), the ProcessedFile class does a fallback to the original file object. Unfortunately, this uses the uid of the original file, as the ProcessedFile class does also do the fallback here. This leads to some random (well, not really random) record in sys_file_processedfile being overwritten with the information of the processed file.

The fix is quite simple: The processed file class should never return the uid of the original file, but always its own one if it has been persisted before, otherwise simply NULL.


Related issues

Related to TYPO3 Core - Bug #44616: Image caching broken for im_noScaleUp = 1ClosedAndreas Wolf2013-01-17

Actions
Related to TYPO3 Core - Bug #45168: Wrong image displayed in FE if not resizedClosedAndreas Wolf2013-02-05

Actions
#1

Updated by Andreas Wolf over 8 years ago

  • Subject changed from uid of processed file may be updated during processing to uid of processed file is sometimes updated during processing
#2

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18145

#3

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18145

#4

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/18153

#5

Updated by Anonymous over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#6

Updated by Riccardo De Contardi almost 4 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF