Bug #45885
closed
LoginController Signal call-by-reference broken
0%
Description
Hey guys,
in TYPO3\CMS\Backend\Controller\LoginController - emitRenderLoginFormSignal the call-by-reference is broken.
There is a missing "&" in the array parameter of the dispatch call:
protected function emitRenderLoginFormSignal(array &$markers) {
$this->getSignalSlotDispatcher()->dispatch('TYPO3\\CMS\\Backend\\Controller\\LoginController', self::SIGNAL_RenderLoginForm, array($this, &$markers));
}
Without the call-by-reference there is no possibility to change the markers
Regards,
Tim
Updated by Gerrit Code Review about 11 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20114
Updated by Gerrit Code Review about 11 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20114
Updated by Wouter Wolters almost 11 years ago
- Status changed from Under Review to Resolved
Abandoned
"Call-time pass-by-reference" triggers a PHP warning. See http://www.php.net/manual/en/language.references.pass.php
Updated by Tim Lochmüller almost 11 years ago
Perhaps we should remove the hook then, because it is not possible to add or manipulate the markers?!
Updated by Riccardo De Contardi over 6 years ago
- Status changed from Resolved to Closed