Bug #46795

Scope of ProcessedFile cannot be modified

Added by Oliver Hader over 6 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
Start date:
2013-03-30
Due date:
% Done:

100%

TYPO3 Version:
6.0
PHP Version:
5.3
Tags:
Complexity:
medium
Is Regression:
Sprint Focus:

Description

A ProcessedFile is used to generate a preview or crop-scaled version of a File. Actually a Task implementing the TaskInterface defines the basics and an accordant Helper object takes care of the modifications to that file. There are pre-process and post-process signals that seem to be useless in modifying the scope of a particular task, however.

Imagine a file shall be pre-processed (e.g. color profile transformation) and that result shall be used for resizing.
The current task implementation is using the original file directly, however the task actually shall define which is the source (the original file) the modifications shall be based on.

This change modifies the TaskInterface with a getSourceFile() method to overcome this limitation.

Associated revisions

Revision 58db018e (diff)
Added by Oliver Hader over 6 years ago

[!!!][BUGFIX] Scope of ProcessedFile cannot be modified

A ProcessedFile is used to generate a preview or crop-scaled
version of a File. Actually a Task implementing the
TaskInterface defines the basics and an accordant Helper
object takes care of the modifications to that file.
There are pre-process and post-process signals that seem to
be useless in modifying the scope of a particular task, however.

Imagine a file shall be pre-processed (e.g. color profile
transformation) and that result shall be used for resizing.
The current task implementation is using the original file
directly, however the task actually shall define which is the
source (the original file) the modifications shall be based on.

This change modifies the TaskInterface with a getSourceFile()
method to overcome this limitation.

Change-Id: I280ea9a0bf056f9eee0a06995ab809fdafb8a11a
Fixes: #46795
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/19438
Reviewed-by: Stefan Neufeind
Tested-by: Steffen Ritter
Reviewed-by: Steffen Ritter
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Revision 91783bd5 (diff)
Added by Oliver Hader over 6 years ago

[!!!][BUGFIX] Scope of ProcessedFile cannot be modified

A ProcessedFile is used to generate a preview or crop-scaled
version of a File. Actually a Task implementing the
TaskInterface defines the basics and an accordant Helper
object takes care of the modifications to that file.
There are pre-process and post-process signals that seem to
be useless in modifying the scope of a particular task, however.

Imagine a file shall be pre-processed (e.g. color profile
transformation) and that result shall be used for resizing.
The current task implementation is using the original file
directly, however the task actually shall define which is the
source (the original file) the modifications shall be based on.

This change modifies the TaskInterface with a getSourceFile()
method to overcome this limitation.

Change-Id: I280ea9a0bf056f9eee0a06995ab809fdafb8a11a
Fixes: #46795
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/19502
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

History

#1 Updated by Gerrit Code Review over 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19438

#2 Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/19502

#3 Updated by Oliver Hader over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Riccardo De Contardi almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF