Project

General

Profile

Actions

Task #46854

closed

Release installation procedure from LocalConfiguration file

Added by Christian Kuhn over 11 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2013-04-01
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.1
PHP Version:
Tags:
Complexity:
hard
Sprint Focus:

Description

The dummy, government and introduction packages deliver with a
default typo3conf/LocalConfiguration.php file to set defaults. If
the installation was not yet completed, those files do not contain
database settings. The bootstrap loads LocalConfiguration and
redirects to the install tool in 123 mode, if those db credentials
are missing. This is ugly and leads to several headaches.

The patch introduces a new file called "FactoryConfiguration.php"
within ext:core Configuration directory to set those defaults now.
The packages can overload these settings with an own file in
typo3conf called "AdditionalFactoryConfiguration", eg. to load the
specific extensions needed during the install process.

This way, the packages do not deliver a "LocalConfiguration" file
anymore. The boostrap now just checks for the existence of the file
and redirects to the install tool if it doesn't exist. The install
tool then creates the "LocalConfiguration" from the factory files
at an early point in the process.

The patch has to deal with different side effect of this:
  • ConfigurationManager is no singleton anymore, there was no reason
    for that in the first place anyway.
  • ConfigurationManager has a new method to deal with the factory
    files.
  • ConfigurationManager got some refactoring to get rid of constants
  • Bootstrap is adapted to the new file existance handling.
  • GeneralUtility::fixPermissions now can give default permission
    values for files if the settings do not exist yet.
  • GeneralUtility::writeFile now accepts a new argument to force
    setting permissions. This is used in ConfigurationManager to
    end up with a LocalConfigurationFile with correct permissions
    as soon as installation is completed.
  • As usual, the patch has a good test coverage to show everything
    works as expected.

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #46895: [BUGFIX] Skip some permissions tests if run as rootClosed2013-04-03

Actions
Actions #1

Updated by Gerrit Code Review over 11 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19506

Actions #2

Updated by Gerrit Code Review over 11 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19506

Actions #3

Updated by Gerrit Code Review over 11 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19506

Actions #4

Updated by Christian Kuhn over 11 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #5

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF