Bug #48127

StorageRepository::findByStorageType() uses wrong default typeField

Added by Frans Saris about 8 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
File Abstraction Layer (FAL)
Target version:
-
Start date:
2013-05-13
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.0
PHP Version:
5.4
Tags:
Complexity:
no-brainer
Is Regression:
Sprint Focus:

Description

By default the StorageRepository::findByStorageType() function tries to search/match the storage by $this->typeField. But $this->typeField has 'type' as default value and that column isn't present in the 'sys_file_storage' database.

In my opinion this has to be:

    /**
     * @var string
     */
    protected $typeField = 'driver';

#1

Updated by Philipp Gampe about 8 years ago

  • Category set to File Abstraction Layer (FAL)
  • Status changed from New to Accepted
  • Assignee set to Philipp Gampe
  • TYPO3 Version changed from 6.1 to 6.0
  • PHP Version set to 5.4

obvious bug, the table only has a field driver

#2

Updated by Gerrit Code Review about 8 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20858

#3

Updated by Gerrit Code Review about 8 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20858

#4

Updated by Gerrit Code Review almost 8 years ago

Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/21993

#5

Updated by Gerrit Code Review almost 8 years ago

Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/21995

#6

Updated by Philipp Gampe almost 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#7

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF