Bug #48467
closedFilelist renders wrong root-icons (expandable or not) for file-mounts
100%
Description
I installed a TYPO3 v6.0.0 installation for someone and now updated to TYPO3 v6.1.0.
The files are all organized in file-mounts, that are linked to storage-objects.
In this project, I have two storage-objects, where one of them has over 5 mounts.
One of my customers informed me, that he was not able to see the subfolders of some of the file-mounts.
As I looked through the code, I found out, that, for the listing, you loop over the list of storageObjects and for each one of them, you fetch a list of file-mounts or take the rootLevelFolder if there is none (f.e. as administrator).
Later on you loop over an array (either the rootLevelFolders or the list of fileMounts) and show the plus/minus/blank sign based on if the storage-object is browsable and the rootLevelFolder has any subfolders.
In my case, the user himself just was allowed to see the fileMounts, not the rootLevelFolder of the storageObject. In this case, it just checked if the first fileMount had subfolders, which wasn't the case.
I fixed the bug by comparing the count of subfolders of the actual fileMount the loop was running over.
Patch is attached ... I don't really know how to put it into Gerrit ... hopefully someone is kindly enough to do it :)
Files
Updated by Wouter Wolters over 11 years ago
Hey Simon,
Thanks for the patch. See for a guide to push to Gerrot here: http://wiki.typo3.org/Contribution_Walkthrough_with_CommandLine
All is explained there to help you push it to Gerrit. If you still have questions. You can reach me on my e-mail (see Forge profile)
Updated by Gerrit Code Review over 11 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20981
Updated by Simon Schick over 11 years ago
Hi, Wouter Wolters
Got it working - just a couple of seconds after your post ;)
Thanks for the link to the wiki.
Updated by Gerrit Code Review over 11 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20981
Updated by Gerrit Code Review over 11 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20981
Updated by Benjamin Rau about 11 years ago
What is the current state of this issue?
Updated by Gerrit Code Review about 11 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20981
Updated by Gerrit Code Review about 11 years ago
Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/23641
Updated by Gerrit Code Review about 11 years ago
Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/23642
Updated by Simon Schick about 11 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 24731b0dc8a0eeb3cbc247d6b93a3af3d9bdbcee.
Updated by Simon Schick about 11 years ago
Is there a reason why this just has been merged to 6.x, the next minor-release, and not to 6.0.x or 6.1.x, the next bugfix-releases?
Updated by Wouter Wolters about 11 years ago
- Is Regression set to No
Because the patches are still pending in the review-queue. master branch aka 6.2 is merged and backports are created but not yet merged.
Updated by Riccardo De Contardi about 7 years ago
- Status changed from Resolved to Closed