Project

General

Profile

Actions

Bug #50855

closed

Add missing semicolon(s) in minified JS file

Added by Michael Schams over 11 years ago. Updated over 11 years ago.

Status:
Rejected
Priority:
Should have
Assignee:
-
Category:
Authentication
Target version:
-
Start date:
2013-08-07
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

TYPO3 CMS 4.5.29 (maybe other versions are affected as well).
The minified JS file rsaauth_min.js shows missing semicolons.

typo3_src-4.5.29/typo3/sysext/rsaauth/resources/rsaauth_min.js

The original (un-minified) file rsaauth.js (same directory) contains the semicolons (see attached screenshot0008.png), but not rsaauth_min.js.

Line 1, column 369 (after "hex2b64(b)") - screenshot0008.png, marker (1)
Line 2, column 102 (after "return") - screenshot0008.png, marker (2)
Line 2, column 290 (after "hex2b64(b)") - screenshot0008.png, marker (3)


Files

screenshot0008.png (99.1 KB) screenshot0008.png rsaauth.js (original, un-minified version) Michael Schams, 2013-08-07 05:25
Actions #1

Updated by Ernesto Baschny over 11 years ago

  • Status changed from New to Needs Feedback

Do you have a problem with that? This is perfectly valid javascript, and the minifier library probably removed them on purpose (to spare some bytes).

Refer for example to: http://www.codecademy.com/blog/78-your-guide-to-semicolons-in-javascript

You need less semicolons in Javascript than you might think.

Agreed?

Actions #2

Updated by Michael Schams over 11 years ago

I came across this when I hunted down a bug and thought, these missing semicolons are causing the issue (with a patched version of rsaauth.js/rsaauth_min.js). The examples at codecademy.com look convincing, so maybe I was on the wrong track.

I will double-check asap, so maybe set this ticket to on hold for the time being or reject it, if you are sure, the semicolons are not required.

Actions #3

Updated by Michael Schams over 11 years ago

Please REJECT this bug report!

I agree, the semicolons are not required. I re-tested the script (without semicolons) and it works and does not cause the errors I got. I was on the wrong track, sorry.

Actions #4

Updated by Alexander Opitz over 11 years ago

  • Status changed from Needs Feedback to Rejected
Actions

Also available in: Atom PDF