Project

General

Profile

Actions

Bug #51190

closed

utf-8/multibyte characters break file list menu item

Added by Peter Niederlag over 10 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2013-08-19
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Steps to reproduce

  1. Create a folder with some umlaut(special character) in your storage (example "Bärentatze")
  2. select the file list module and jump around your files and folders. this works pretty nice
  3. select folder "Bärentatze" or a folder underneath
  4. switch to some other random module (page, list, ...)
  5. select file list module again on the left
  6. <peng /> due to some escape/encoding issues the file list will report a failure on first access

Source of problem

In typo3/sysext/filelist/Classes/Controller/FileListController.php the following line will become part of the created inline Javascript(!):

if (top.fsMod) top.fsMod.recentIds["file"] = unescape("' . rawurlencode($this->id) . '");

unfortunatly unescape(javascript) will only work on ASCII but not on utf8. It even seems unecessary to decode the string at all, rawurlencode prepares the string in a way that can be consumed for usage as part of an url straight away.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #51319: Broken error handling for not existing folderClosed2013-08-24

Actions
Actions #1

Updated by Gerrit Code Review over 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23278

Actions #2

Updated by Peter Niederlag over 10 years ago

  • TYPO3 Version changed from 6.1 to 6.2
Actions #3

Updated by Anonymous over 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #4

Updated by Peter Niederlag over 10 years ago

  • Status changed from Resolved to Under Review
  • % Done changed from 100 to 0

wrong status update by push in privat sandbox branch :(
The patch is still pending for +2

Actions #5

Updated by Gerrit Code Review over 10 years ago

Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/23378

Actions #6

Updated by Anonymous over 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Gerrit Code Review over 10 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master_new has been pushed to the review server.
It is available at https://review.typo3.org/23411

Actions #8

Updated by Peter Niederlag over 10 years ago

  • Status changed from Under Review to Resolved

issue is fixed and merged to master(6.2) and 6.1

Actions #9

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF