Project

General

Profile

Actions

Task #51283

closed

Use array access instead of traversing hook array

Added by Bernhard Kraft about 11 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Content Rendering
Target version:
Start date:
2013-08-23
Due date:
% Done:

100%

Estimated time:
2.00 h
TYPO3 Version:
6.2
PHP Version:
5.4
Tags:
Complexity:
easy
Sprint Focus:

Description

In "TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer" in method "cObjGetSingle" the array of hook objects is traversed to look for a hook object for the currently rendered cObject. This is not fast.

Instead check if there is a hook object for the current cObject defined by making an array access.

Patch attached.


Files

patch_51283.diff (1000 Bytes) patch_51283.diff Bernhard Kraft, 2013-08-23 10:33
Actions #2

Updated by Gerrit Code Review about 11 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23267

Actions #3

Updated by Gerrit Code Review almost 11 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/23267

Actions #4

Updated by Gerrit Code Review almost 11 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/23267

Actions #5

Updated by Gerrit Code Review almost 11 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/23267

Actions #6

Updated by Anonymous almost 11 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 30 to 100
Actions #7

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF