Project

General

Profile

Actions

Bug #51981

closed

JPEG files don't get processed to JPG, only JPG files do.

Added by Guido Jansen over 10 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2013-09-13
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.1
PHP Version:
5.3
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

If I upload a JPG image with the file extension '.jpeg' and crop it via ImageMagick or GD, the image is rendered as PNG or GIF file no matter what value $GLOBALS['TYPO3_CONF_VARS']['GFX']['thumbnails_png'] has.

In file typo3/sysext/core/Classes/Resource/Processing/AbstractGraphicalTask.php
In line 103

it says
if ($this->getSourceFile()->getExtension() === 'jpg') {

should better be
if ($this->getSourceFile()->getExtension() === 'jpg' || $this->getSourceFile()->getExtension() === 'jpeg') {

or perhaps even better via the mime code

Actions #1

Updated by Gerrit Code Review over 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23810

Actions #2

Updated by Markus Klein over 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #3

Updated by Gerrit Code Review over 10 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/23815

Actions #4

Updated by Gerrit Code Review over 10 years ago

Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/23816

Actions #5

Updated by Markus Klein over 10 years ago

  • Status changed from Under Review to Resolved
Actions #6

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF