Bug #52437

Task #49162: Rewrite install tool

Don't write LocalConfiguration on every Install Tool entry

Added by Ernesto Baschny almost 6 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Must have
Category:
Install Tool
Target version:
Start date:
2013-10-01
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Silent Updater "removeObsoleteLocalConfigurationSettings" will always kick in and save the current LocalConfiguration even if nothing has to be changed.

If you have a non-writeable LocalConfiguration.php you will then end up in an Exception in this step already, without the installer having a chance to kick in and handle it in a more "gentle" way (needs improvements too, will need some further issues).

Associated revisions

Revision 1c434913 (diff)
Added by Ernesto Baschny almost 6 years ago

[BUGFIX] Don't write LocalConfiguration on every Install Tool entry

Make removeObsoleteLocalConfigurationSettings only rewrite the
file if something has changed.

Resolves: #52437
Releases: 6.2
Change-Id: I014fa04659d1ca8435d576c85ab039a9ee0bf92b
Reviewed-on: https://review.typo3.org/24221
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

History

#1 Updated by Gerrit Code Review almost 6 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24221

#2 Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24221

#3 Updated by Ernesto Baschny almost 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Christian Kuhn almost 6 years ago

  • Parent task set to #49162

#5 Updated by Riccardo De Contardi over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF