Task #52501
closed
Adjust font-size and headline sizes
Added by Felix Kopp over 10 years ago. Updated over 6 years ago.
100%
Description
Set body base font-size system-wide. Adjust base font size and increase by 1 Pixel. Inherit base font size for headline based on relative sizes.
Files
| 52501-before.png (92.3 KB) 52501-before.png | Before | Felix Kopp, 2013-10-03 13:31 | |
| 52501-after.png (95.9 KB) 52501-after.png | After | Felix Kopp, 2013-10-03 13:31 |
Updated by Gerrit Code Review over 10 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24307
Updated by Felix Kopp over 10 years ago
- File 52501-before.png 52501-before.png added
- File 52501-after.png 52501-after.png added
Before
After
Updated by Felix Kopp over 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 523ba3399a07f99249fdbc27682253af702bcaf7.
Updated by Ernesto Baschny over 10 years ago
- Category set to Backend User Interface
- Status changed from Resolved to Needs Feedback
- Target version set to 6.2.0
- % Done changed from 100 to 50
While I appreciate changes in font sizes, my impression is that this was rushed in somehow unfinished. Maybe I just miss the discussion around it, but I wonder how this could go past review. There are now tons of inconsistencies in the backend because we have several "hard-coded" 11px and 10px font-sizes still around. Now there is a mix of "large" and "small" fonts.
The whole ExtJS "theme" is based on overriding font-size's (with !important), so page tree, workspaces, recycler etc are all not affected yet. All SELECT boxes still use smaller fonts. Several tables which use tree's formed with the icons from sysext/t3skin/icons/gfx/ol now have a gap: all those icons will need to be redrawn to cope with the larger line height (see i.e. Web>Access "Permissions"). The Modules menu is not affected by the font size change yet, etc etc.
What's the plan with this? Is this is WIP? Are there already plans to fix that in form of "other issues"? Wouldn't it be more stable to develop the whole changeset in one patchset instead of first merging this semi-solution which now "someone" needs to fix?
Updated by Felix Kopp over 10 years ago
Thank you for your feedback and review. Please let us find a good way to solve the outstanding task which need to be solved for years.
The change in body/base font-size if not the central task here. But the base font-size should be increased by 1px also the line-height must be set centrally and increased. The central tasks are
- Become independent of font-size definitions all over the place.
- Get proper inheritance for font-sizes (bases on "em" / percentages)
- Make trees/tables line-height/height independent
-> The inconsistencies in font-sizes are not introduced with this changeset but already exist for long time. The font-sizes in the backend were 10px and 11px which have been are different before (please see FlashMessages header and content font-size - still on master).
Please also have a close look at backend modules in commit a727959a62694e37b4b1de9d811989444466fd2a / before font-size change. Tables / trees have been disconnected for a long time beforehand.
Yes, there are follow-ups patched WIP already. Please consider https://review.typo3.org/#/c/24299/ also see the comment in element_table.css (merged) at https://review.typo3.org/#/c/24425/3/typo3/sysext/t3skin/Resources/Public/Css/structure/element_table.css line 48 to solve "taller" icons in tables - as the permission module for example. Discussed approach for tables with tall tree/icons here http://forge.typo3.org/issues/45502 you will find the approach & solution for Access module.
All !importants and font-sizes should be removed (see propotype in EXT: flat). Yes, icons must be redrawn. The icons are finished already: I will push the icons standalone to convince you of the status. Problem here: all tables must be unified in order to get the table/tree listing completed with new icons. Please consider all corresponding patched for tables.
The whole topic font-sizes and tables (with 0.9em font-size) was discussed at ACME in HH - first patches were
#49743
#49635
#49603
#49593
#49596
#49647
We realized the need to get line-height/height independent which testing bootstrap/zurb in the backend. Table/line-height definitions should also incorporate the EM font-size definitions.
Easy approach for now:
Decrease body font-size to 11px (instead of 12px) -> Clean up CSS beforehand -> than propose body font-size adaption again.
I will send a simple follow-up patch for that. - Please merge if you prefer that road. Ok?
Updated by Ernesto Baschny over 10 years ago
- Status changed from Needs Feedback to Resolved
- Estimated time set to 0.00 h
This is now resolved by #52497 which is merged into core.
Updated by Riccardo De Contardi over 6 years ago
- Status changed from Resolved to Closed