Feature #52693
closed
Unused $requestedId local variable
100%
Description
There's a local variable $requestedId in typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php:1345 which store the original requested id before changing it. This variable is not used at all but can be usefull for a hook or class override.
Because this variable is unused and inacessible, could you set it as (protected) property ? I join the patch.
Files
Updated by GAYA La Nouvelle Agence over 10 years ago
Here's the patch for typo3 6.1.5
Updated by GAYA La Nouvelle Agence over 10 years ago
I've forgot to add the public method for getting it. Here's the new patch.
Updated by Mathias Schreiber about 9 years ago
- Target version changed from 6.2.0 to 7.2 (Frontend)
Updated by Gerrit Code Review about 9 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36828
Updated by Gerrit Code Review about 9 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36828
Updated by Frederic Gaus about 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 49f5a9f110c82ee1491b9e4380bf55df0be23bf4.
Updated by Riccardo De Contardi over 6 years ago
- Status changed from Resolved to Closed