Project

General

Profile

Actions

Feature #52693

closed

Unused $requestedId local variable

Added by GAYA La Nouvelle Agence about 11 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Frontend
Target version:
Start date:
2013-10-11
Due date:
% Done:

100%

Estimated time:
PHP Version:
Tags:
Complexity:
easy
Sprint Focus:

Description

There's a local variable $requestedId in typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php:1345 which store the original requested id before changing it. This variable is not used at all but can be usefull for a hook or class override.

Because this variable is unused and inacessible, could you set it as (protected) property ? I join the patch.


Files

TypoScriptFrontendController.patch (842 Bytes) TypoScriptFrontendController.patch GAYA La Nouvelle Agence, 2013-10-11 12:20
TypoScriptFrontendController.patch2 (1.18 KB) TypoScriptFrontendController.patch2 GAYA La Nouvelle Agence, 2013-10-11 12:38
Actions #2

Updated by GAYA La Nouvelle Agence about 11 years ago

I've forgot to add the public method for getting it. Here's the new patch.

Actions #3

Updated by Mathias Schreiber almost 10 years ago

  • Target version changed from 6.2.0 to 7.2 (Frontend)
Actions #4

Updated by Frederic Gaus almost 10 years ago

  • Tracker changed from Bug to Feature
Actions #5

Updated by Gerrit Code Review almost 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36828

Actions #6

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36828

Actions #7

Updated by Frederic Gaus over 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Riccardo De Contardi about 7 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF