Task #53581: Remove useless comment in layout of viewpage - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Task #53581

closed

Remove useless comment in layout of viewpage

Added by Eric Chavaillaz about 11 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Code Cleanup

Target version:

next-patchlevel

Start date:

2013-11-13

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

6.2

PHP Version:

5.3

Tags:

Complexity:

Sprint Focus:

Description

Hi,

After resolving the issue #52616, the comment above the icon view helper is false (see #25293, now "target" is available through additionalAttributes) and useless. We must delete it.

<f:comment>
    Uri was added by javascript window.open and not a simple <a href>
    because f:be.buttons.icon does not support the target parameter.
</f:comment>

Thanks.

Actions

Copy link

Updated by Gerrit Code Review about 11 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25362

Actions

Copy link

Updated by Gerrit Code Review about 11 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25362

Actions

Copy link