Project

General

Profile

Actions

Bug #54252

closed

Empty container for tabs titles when using dividers2tabs => FALSE in ext_tables

Added by Marcin Sągol almost 11 years ago. Updated almost 10 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Backend User Interface
Target version:
Start date:
2013-12-06
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.4
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

If we set 'dividers2tabs' property to FALSE in ext_tables.php than when editing such configured record we will see something like 2px height line. This is because empty DIV with class 'typo3-dyntabmenu-divs' is rendered and it has in styles defined border top and bottom.

Se attached screenshot.


Files

empty_tabs_container.jpg (49.4 KB) empty_tabs_container.jpg Marcin Sągol, 2013-12-06 22:57
valid_inline_structure.jpg (44.9 KB) valid_inline_structure.jpg Marcin Sągol, 2014-01-31 12:40
Actions #1

Updated by Marcin Sągol almost 11 years ago

Ok the problem is that the whole content/form is rendered outside div.typo3-dyntabmenu-divs but should be inside this div.

Actions #2

Updated by Marcin Sągol almost 11 years ago

In typo3/sysext/backend/Classes/Form/FormEngine.php line 906: $output = '<div class="typo3-dyntabmenu-divs">' . $output . '</div>'; valid code is generated and returned. So somewhere alse it gets broken.

Actions #3

Updated by Marcin Sągol almost 11 years ago

Next check. In typo3/sysext/backend/Classes/Form/Element/InlineElement.php line 415 we have valid content (table inside div) but in next line wrapFormSections() function is called:

$fields = $this->wrapFormsSection($fields);

and after this our content lands in <table> ... </table> tags so this results with invalid structure (div is rendered after table and before tr tags and browsers puts it probably outside first table tag):

<table >
<div class="typo3-dyntabmenu-divs">
<tr>
<td colspan="2">
<table border="0" cellspacing="0" cellpadding="0" width="100%" class="wrapperTable1">
<tr class="class-main12">
<td colspan="2" class="formField-header"><span style="color:;" class="class-main14"><strong>Język:</strong></span></td>
...
</td>
</tr>
</table>
</td>
</tr>
</div>
</table>

Actions #4

Updated by Marcin Sągol almost 11 years ago

So if there are not any tabs defined and we do not pass $fields through $this->wrapFormsSection() function we will have nice and valid structure (see attached screen).

Actions #5

Updated by Marcin Sągol almost 11 years ago

Ok i need some feedback here. Are the dynatabs designed to work without single tab (only tab content) or not (if no is it intentional)?

Actions #6

Updated by Mathias Schreiber almost 10 years ago

  • Status changed from New to Closed
  • Assignee set to Marcin Sągol

Hi Marcin,

could you check whether our rebuild in CMS7 fixed the issue for you?
If so, leave the ticket closed.
If not, please open it up again.

Thanks in advance

Actions

Also available in: Atom PDF