Feature #54513

linkvalidator: improve tolerance for forbidden HEAD requests

Added by Alexander Stehlik almost 6 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Linkvalidator
Target version:
-
Start date:
2013-12-19
Due date:
% Done:

100%

PHP Version:
5.3
Tags:
Complexity:
easy
Sprint Focus:

Description

Currently the linkhandler will first try a HEAD request to check an external link.

If the server returns the correct response code (405 - Method not allowed) it will retry the request using the GET method.

Unfortunately I stumbled over some misconfigured servers that will return 403 - Forbidden response codes when the HEAD method is used. In that case the linkvalidator will report a broken link, even though the GET request would work fine.

Of course it would be nice if all servers are configured correctly but there probably will always be some that are not.

So my suggestion is to also retry the GET request on 403 errors or alternatively make the response codes configurable that trigger a fallback GET request.


Related issues

Related to TYPO3 Core - Bug #58145: Linkvalidator - HEAD response codes Closed 2014-04-24

Associated revisions

Revision c3b1bede (diff)
Added by Alexander Stehlik over 5 years ago

[TASK] Retry request on 403 in linkvalidator

When the linkvalidator detects a 403 error when doing a HEAD request to
an external URL it will retry the request using the GET method.

Resolves: #54513
Releases: 6.2
Change-Id: Ib36b6cbb8e981b95c348afd5a063ca4f5040de75
Reviewed-on: https://review.typo3.org/26489
Reviewed-by: Markus Klein
Tested-by: Markus Klein

History

#1 Updated by Gerrit Code Review almost 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26489

#2 Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26489

#3 Updated by Gerrit Code Review almost 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26489

#4 Updated by Gerrit Code Review almost 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26489

#5 Updated by Gerrit Code Review over 5 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26489

#6 Updated by Alexander Stehlik over 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF