Project

General

Profile

Actions

Bug #54743

closed

class_exists() in GeneralUtility::getClassName() should not autoload class

Added by Michiel Roos almost 11 years ago. Updated over 10 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Performance
Target version:
-
Start date:
2014-01-05
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.3
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

Maybe there are more places where class_exists should not autoload the class.

The comments before a call to class_exists() and the call to class_exists() should explicitly state if the autoloading is required or not.


Files

test_2.4.0_201401272050.zip (2.7 KB) test_2.4.0_201401272050.zip XClass test extension Michiel Roos, 2014-01-27 20:51
test_2.4.1_201401272335.zip (2.99 KB) test_2.4.1_201401272335.zip Helmut Hummel, 2014-01-27 23:35
Actions #1

Updated by Gerrit Code Review almost 11 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26790

Actions #2

Updated by Michiel Roos almost 11 years ago

Uploaded Xclass test extension

Actions #3

Updated by Helmut Hummel almost 11 years ago

Uploaded updated test extension

Actions #4

Updated by Helmut Hummel almost 11 years ago

  • Status changed from Under Review to Needs Feedback

Please see my comments in Gerrit.

I don't think we get anywhere without breaking GeneralUtility::getClassName()

Actions #5

Updated by Alexander Opitz over 10 years ago

  • Target version deleted (6.2.0)

@Michiel: As the patchset was abandoned, can this issue be closed?

Actions #6

Updated by Michiel Roos over 10 years ago

Yes, please close.

Actions #7

Updated by Alexander Opitz over 10 years ago

  • Status changed from Needs Feedback to Closed
Actions

Also available in: Atom PDF