Task #55043
closed
Ensure usage of base constants in the core
100%
Description
All core code should be checked for usage of TYPO3 defined constants instead of calling methods / functions.
It's more expensive to call chr(10) multiple times than to use the LF constant.
\TYPO3\CMS\Core\Core\SystemEnvironmentBuilder::defineBaseConstants() Defines many constants which should be used.
The CGL must clearly emphasise the availability of the constants.
Updated by Gerrit Code Review over 10 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30722
Updated by Gerrit Code Review over 10 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30722
Updated by Gerrit Code Review about 10 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30722
Updated by Gerrit Code Review about 10 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30722
Updated by Gerrit Code Review almost 10 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30722
Updated by Gerrit Code Review almost 10 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30722
Updated by Tomita Militaru almost 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 1491cdb31b604612039d4538124fe67195814b4d.
Updated by Riccardo De Contardi about 7 years ago
- Status changed from Resolved to Closed