Bug #55507: Icons above page tree and in toolbar shifted - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #55507

closed

Epic #57533: Pagetree epic

Icons above page tree and in toolbar shifted

Added by Stephan Großberndt almost 11 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Stephan Großberndt

Category:

Backend User Interface

Target version:

Start date:

2014-01-31

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

6.2

PHP Version:

Tags:

Complexity:

easy

Is Regression:

Yes

Sprint Focus:

Description

Another regression introduced by Core - Task #52497: Simplify Font-Size inheritance (CSS):

The icons above the page tree (new/filter/refresh) and in the toolbar shifted to bottom. This is due to removing the rule

.x-toolbar td,.x-toolbar span,.x-toolbar input,.x-toolbar div,.x-toolbar select,.x-toolbar label{        
       font:normal 10px verdana, arial,tahoma, helvetica, sans-serif;        
}

from xtheme-t3skin.css

font:normal sets line-height:normal too. This was removed, now only

line-height: 1.5em;

from body applies.

Files

comparison-55507.png (14.5 KB) comparison-55507.png

Andreas Wolf, 2014-02-02 10:48

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Gerrit Code Review almost 11 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27196

Actions

Copy link

Updated by Gerrit Code Review almost 11 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27196

Actions

Copy link

Updated by Gerrit Code Review almost 11 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27196

Actions

Copy link

Updated by Andreas Wolf almost 11 years ago

File comparison-55507.png comparison-55507.png added

I'd rather not have this go in, as the styling for the normal buttons is improved, but when the buttons are clicked, the margin at top and bottom does not fit (see attached screenshot).

Actions

Copy link

Updated by Felix Kopp over 10 years ago

Parent task set to #57533

Actions

Copy link

Updated by Felix Kopp almost 10 years ago

Patch pending on forge. Please follow-up

Actions

Copy link

Updated by Gerrit Code Review almost 10 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/27196

Actions

Copy link

Updated by Gerrit Code Review almost 10 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35425

Actions

Copy link

Updated by Gerrit Code Review almost 10 years ago

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35425

Actions

Copy link

#10