Bug #55510
closedSelects have a ugly padding
100%
Description
Bugfix #55319 "Buttons" sets padding and margin for all selects:
.t3-button, input, textarea, select, button { padding: 3px 6px; margin: 0 0.5em 0.5em 0; }
This is a new rule and looks ugly.
Files
Updated by Stephan Großberndt over 10 years ago
- File select-padding2.png select-padding2.png added
Updated by Gerrit Code Review over 10 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27190
Updated by Gerrit Code Review over 10 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27190
Updated by Gerrit Code Review over 10 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27190
Updated by Stephan Großberndt over 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 9f04a809d06913080867be305e0d945f43650007.
Updated by Mathias Brodala over 10 years ago
Just as a note: this could have actually improved usability quite a bit since the hit area for the select was larger.
"Ugly" is a rather subjective justification for removing this.
Updated by Felix Kopp over 10 years ago
Also now the select fields are not of the equal height of input fields & submit/buttons.
I included the padding to gain similar sizes for all form elements.
What exactely is the reason to remove the padding besides the white background?
Updated by Felix Kopp over 10 years ago
consequence of different sizes
Updated by Stephan Großberndt over 10 years ago
The reason is e.g. selects in typo3-docheader:
The select is too high for it due to the (new introduced) padding.
The dropdown-indicator does not look good in all browsers. Some do not move the dropdown-indicator to the right. A possible solution for that might be using something like http://cssdeck.com/labs/styling-select-box-with-css3
Updated by Benni Mack almost 6 years ago
- Status changed from Resolved to Closed