Project

General

Profile

Actions
Copy link

Task #55589

closed

Redundant method: ResourceCompressor::checkBaseDirectory

Added by Michiel Roos almost 11 years ago. Updated about 9 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2014-02-02
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.3
Tags:
Complexity:
no-brainer
Sprint Focus:

Description

\TYPO3\CMS\Core\Resource\ResourceCompressor::checkBaseDirectory() is a thick wrapper around GeneralUtilty::isFirstPartOfStr().

It's thick because it does not return the boolean result directly but first interprets is as a boolean and then returns TRUE or FALSE based on that.

On the login screen /typo3/, this method is called 110 times. The time spent inside the method (excluding isFirstPartOfStr() time) is 3.11 needless microseconds.

This wrapper method should be deprecated and the GeneralUtilty::isFirstPartOfStr() called directly.

Actions
Copy link
 #1

Updated by Alexander Opitz over 9 years ago

  • Status changed from New to Needs Feedback
  • Target version changed from 6.2.0 to 7.5

But the functionality is needed to test more then one baseDirectory, I don't see another way around this.

Actions
Copy link
 #2

Updated by Alexander Opitz about 9 years ago

  • Status changed from Needs Feedback to Closed
  • Target version deleted (7.5)

No feedback within the last 90 days => closing this issue.

If you think that this is the wrong decision or experience this issue again, then please write to the mailing list typo3.teams.bugs with issue number and an explanation or open a new ticket and add a relation to this ticket number.

Actions
Copy link

Also available in: Atom PDF