Bug #56262
closedIndexed search makes search result Title wrong - htmlspecialchars
100%
Description
Indexed search has error during creation item_title field.
There is an error in SearchController:
in method 'compileSingleResultRow' (line 349) is called 'htmlspecialchars' function ($title field) and then again in 'linkPage' method (line 1186) when returning a tag with the title performing same function again, what makes mess.
Example:
First time performing 'htmlspecialchars' makes from this string Preisverleihung und Preisträger & "2"013 -> Preisverleihung und Preisträger & "2"013 and second performing same method makes this -> Preisverleihung und Preisträger & "2"013 what can't be returned in normal string in FE.
My patch was just to remove line 349 from 'compileSingleResultRow' method:
$title = htmlspecialchars($title);
and it's gonna make nice special character in Title field.
P.S. I attached 2 picture showing search results before and after patch.
Files
Updated by Dragan Tomic almost 11 years ago
Just to format with 'pre' tag (forgot to preview :) ):
Original string *Preisverleihung und Preisträger & "2"013* -> *Preisverleihung und Preisträger & "2"013* (after first performing htmlspecialchars) and wrong one *Preisverleihung und Preisträger & "2"013* (after second performing htmlspecialchars on Title field).
Updated by Gerrit Code Review almost 11 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27849
Updated by Gerrit Code Review almost 11 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27849
Updated by Gerrit Code Review almost 11 years ago
Patch set 1 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27998
Updated by Gerrit Code Review almost 11 years ago
Patch set 1 for branch TYPO3_6-0 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27999
Updated by Markus Klein almost 11 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 69c103b2637a94ca0ca7a9c59b6cd7706eaf60fc.