Project

General

Profile

Actions

Bug #56408

closed

Quickedit mode - RTE has no user CSS

Added by d.ros no-lastname-given about 10 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Category:
RTE (rtehtmlarea + ckeditor)
Target version:
Start date:
2014-02-28
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.1
PHP Version:
5.4
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

In normal page "columns" module the RTE respects the user CSS included with RTE.default.contentCSS.

In page "quickmode" this css is not included.

IMHO the CSS should always be included to have a consistent UX.

Only tested in 6.1.7 - dunno if this also fails in 6.2.x

Actions #1

Updated by d.ros no-lastname-given about 10 years ago

  • Target version set to next-patchlevel

Found the cause

ONLY IN QUICKEDIT MODE the path is wrong

PHP Warning: file_exists(): open_basedir restriction in effect. File(/var/www/fileadmin/path/to/the/file/in/USER_RTE_MASTER.css) is not within the allowed path(s): 

The path must be

/var/www*/user/html/*fileadmin/path/to/the/file/in/USER_RTE_MASTER.css

There must be a bogus in the quickedit script.

Actions #2

Updated by Stanislas Rolland almost 10 years ago

This issue does not seem be exist in TYPO3 6.2.

Where is the warning raised?

Actions #3

Updated by Falk Gebauer over 9 years ago

This issue also exists in 6.2 incl. 6.2.4.

The warning is raised if you have e.g. set open_basedir restrictions, the RTE.default.contentCSS and enter the QuickEdit mode in the Page module.

PHP Warning
PHP Warning: file_exists(): open_basedir restriction in effect. 
File(/var/typo3conf/ext/xxx/Resources/Public/StyleSheet/Rte.css) 
is not within the allowed path(s): (/var/www/xxxxx/web:/var/www/xxxxx/tmp:/usr/share/php5:/tmp) in 
/var/www/xxxxx/web/TYPO3.CMS/typo3/sysext/rtehtmlarea/Classes/RteHtmlAreaBase.php line 534

In RteHtmlAreaBase::getContentCssFileName the absolute path to the css file is miscalculated if QuickEdit mode is choosen.

Maybe changing

if ($fileName) {
    $fileName = $this->getFullFileName($fileName);
}
$absolutePath = $fileName ? GeneralUtility::resolveBackPath(PATH_site . ($this->is_FE() || $this->isFrontendEditActive() ? '' : TYPO3_mainDir) . $fileName) : '';

to

$absolutePath = $fileName ? GeneralUtility::getFileAbsFileName($fileName) : '';        
if ($fileName) {
    $fileName = $this->getFullFileName($fileName);
}

will solve this.

Actions #4

Updated by Gerrit Code Review over 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33568

Actions #5

Updated by Gerrit Code Review over 9 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33569

Actions #6

Updated by Stanislas Rolland over 9 years ago

  • Assignee set to Stanislas Rolland

Please test this change: https://review.typo3.org/#/c/33569/

Actions #7

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33568

Actions #8

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33569

Actions #9

Updated by Gerrit Code Review over 9 years ago

Patch set 3 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33569

Actions #10

Updated by Gerrit Code Review over 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33568

Actions #11

Updated by Gerrit Code Review over 9 years ago

Patch set 4 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33569

Actions #12

Updated by Stanislas Rolland over 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #13

Updated by Stanislas Rolland over 9 years ago

  • Status changed from Resolved to New
Actions #14

Updated by Gerrit Code Review over 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33821

Actions #15

Updated by Stanislas Rolland over 9 years ago

  • Status changed from Under Review to Resolved
Actions #16

Updated by Gerrit Code Review over 9 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33823

Actions #17

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33823

Actions #18

Updated by Stanislas Rolland over 9 years ago

  • Status changed from Under Review to Resolved
Actions #19

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF