Cleanup main_rte function in the ElementBrowser and children
main_rte method of the ElementBrowser has over 440lines.
A lot of code is duplicated between parent and child classes.
This duplicated code already costed us some headaches - some bugs were fixed in one place and not in the other.
We should split main_rte into smaller chunks to and remove duplicates.
[CLEANUP] main_rte function of the ElementBrowser
It splits 450 lines function into smaller pieces
and removes some duplicated code in the process.
It also opens a way to further duplicate removal
e.g. the code for selecting current folder.
This patch is not changing functionality,
just moving code around.
- splits main_rte into smaller chunks
- make main_rte method signature be consistent
between class implementations and usage
- removes ~100 lines of duplicated code
getPageSelectorHtml and getFileSelectorHtml
are now inherited in the BrowseLinks
- removed few "@todo Define visibility" for methods
which are called from outside
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring