Bug #56781

Cleanup main_rte function in the ElementBrowser and children

Added by Tymoteusz Motylewski over 5 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2014-03-11
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

main_rte method of the ElementBrowser has over 440lines.
A lot of code is duplicated between parent and child classes.
This duplicated code already costed us some headaches - some bugs were fixed in one place and not in the other.
We should split main_rte into smaller chunks to and remove duplicates.

Associated revisions

Revision e8442b8b (diff)
Added by Tymoteusz Motylewski over 5 years ago

[CLEANUP] main_rte function of the ElementBrowser

It splits 450 lines function into smaller pieces
and removes some duplicated code in the process.
It also opens a way to further duplicate removal
e.g. the code for selecting current folder.
This patch is not changing functionality,
just moving code around.

  • splits main_rte into smaller chunks
  • make main_rte method signature be consistent
    between class implementations and usage
  • removes ~100 lines of duplicated code
    getPageSelectorHtml and getFileSelectorHtml
    are now inherited in the BrowseLinks
  • removed few "@todo Define visibility" for methods
    which are called from outside

Resolves: #56781
Releases: 6.3
Change-Id: I7679017b1e215ea2d4da46fa30314313bc9980c5
Reviewed-on: https://review.typo3.org/28269
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

History

#1 Updated by Gerrit Code Review over 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28269

#2 Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28269

#3 Updated by Gerrit Code Review over 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28269

#4 Updated by Gerrit Code Review over 5 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28269

#5 Updated by Gerrit Code Review over 5 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28269

#6 Updated by Gerrit Code Review over 5 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28269

#7 Updated by Gerrit Code Review over 5 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28269

#8 Updated by Tymoteusz Motylewski over 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#9 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF