Bug #56796
closed
Early return in render_textpic leaves registers unrestored
100%
Description
In the CssStyledContentController class there is the method render_textpic.
On the one hand it contains the feature "preRenderRegisters" in line 474 and line 1076, which makes use of LOAD_REGISTER.
On the other hand it contains two early returns in line 488 and 493.
So having an empty image list or a list of images with empty values will leave the loaded registers unrestored.
Solution: Always restore the registers before returning.
I didn't check, if this is already the same for earlier versions, but the reporter of #56536 mentioned at least TYPO3 6.1 to behave similarly.
Patch will follow immediately.
Updated by Gerrit Code Review over 10 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28280
Updated by Gerrit Code Review over 10 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28280
Updated by Jo Hasenau over 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset dd146826cb02149c145dcfc2de47b317d3fa21f8.
Updated by