Project

General

Profile

Actions

Bug #56796

closed

Early return in render_textpic leaves registers unrestored

Added by Jo Hasenau over 10 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
Content Rendering
Target version:
Start date:
2014-03-11
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.4
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

In the CssStyledContentController class there is the method render_textpic.

On the one hand it contains the feature "preRenderRegisters" in line 474 and line 1076, which makes use of LOAD_REGISTER.
On the other hand it contains two early returns in line 488 and 493.

So having an empty image list or a list of images with empty values will leave the loaded registers unrestored.

Solution: Always restore the registers before returning.

I didn't check, if this is already the same for earlier versions, but the reporter of #56536 mentioned at least TYPO3 6.1 to behave similarly.
Patch will follow immediately.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #53764: Use FAL methods for css_styled_image textpic renderingClosed2013-11-19

Actions
Actions #1

Updated by Gerrit Code Review over 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28280

Actions #2

Updated by Gerrit Code Review about 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28280

Actions #3

Updated by Jo Hasenau about 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #4

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF