Bug #57180

Duplicated array keys in tests

Added by Tymoteusz Motylewski over 5 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Category:
Tests
Target version:
-
Start date:
2014-03-22
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

In few tests dataproviders have duplicated array keys, which results in some cases not being tested.
e.g. in the canGenerateForParametersDataprovider() method of the CacheHashCalculatorTest
'Only the relevant parts should be taken into account' => array('&key=value&exclude1=val', $knowHash),
'Only the relevant parts should be taken into account' => array('&exclude2=val&key=value', $knowHash),

Associated revisions

Revision 0d8d4641 (diff)
Added by Tymoteusz Motylewski over 5 years ago

[TASK] Fix duplicated array keys in tests

In few tests dataproviders have duplicated array keys,
which results in some cases not being tested.
This patch removes duplicated entries and changes array
key names where needed.

Resolves: #57180
Releases: 6.2
Change-Id: I68ea38f89ed7f304b57165ca1d225ffdbe2a7a15
Reviewed-on: https://review.typo3.org/28641
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

History

#1 Updated by Gerrit Code Review over 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28641

#2 Updated by Tymoteusz Motylewski over 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#3 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF