Bug #59000

Code Cleanups in ExtraPageContextMenuOptions

Added by Sebastian Michaelsen over 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Code Cleanup
Target version:
-
Start date:
2014-05-21
Due date:
% Done:

0%

TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

\TYPO3\CMS\ExtraPageCmOptions\ExtraPageContextMenuOptions could use a few cleanups:

  • Use local variables with type hinting instead of $GLOBALS['BE_USER'] and $GLOBALS['LANG']
  • Don't use & on object function parameters (objects are always automatically passed by reference)
  • Rename and type-hint the "$backRef" parameter

History

#1 Updated by Gerrit Code Review over 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30254

#2 Updated by Benni Mack almost 5 years ago

  • Status changed from Under Review to Closed

extension is gone.

Also available in: Atom PDF