Project

General

Profile

Actions

Bug #59692

closed

edit_wideDocument was removed, bring it back - reloaded

Added by Jan Loderhose over 9 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
Backend User Interface
Target version:
Start date:
2014-06-20
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
easy
Is Regression:
Yes
Sprint Focus:

Description

According to issue Bug #57295 (Resolved): Remove option "edit_wideDocument" (http://forge.typo3.org/issues/57295) "the historical option wide Document can be safely removed, as the wide screen options from 10 ys ago are default by now."

Well, rtehtmlarea still relies on this option in TYPO3 6.2.3 and refers to in both, in source code and documentation ...

/typo3/sysext/rtehtmlarea/Classes/Controller/FrontendRteController.php:
/typo3/sysext/rtehtmlarea/Classes/RteHtmlAreaBase.php

http://docs.typo3.org/typo3cms/extensions/rtehtmlarea/6.2/Configuration/UserTsconfig/Index.html

The result is silent ignorance of the officially documented options.

What's wrong here? Core implementation or core extension implementation and documentation?


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #57295: Remove option "edit_wideDocument"ClosedBenni Mack2014-03-25

Actions
Actions #1

Updated by Markus Klein over 9 years ago

I see that the option is still mentioned in the docs, but I can't find it in the code. Can you please guide me there? Thanks

Actions #2

Updated by Jan Loderhose over 9 years ago

My bad! I posted this issue with haste and mixed things up ... Very sorry!

To get the whole/right context please have a look at https://review.typo3.org/#/c/28769/4/typo3/sysext/backend/Classes/Form/FormEngine.php. On line 659 a variable docLarge is set depending on edit_wideDocument. docLarge is the variable that rtehtmlarea still refers to.

[xxx]:/srv/typo3/typo3src/typo3_src-6.2.3> grep -r docLarge .
./typo3/sysext/rtehtmlarea/Classes/Controller/FrontendRteController.php: $width = 460 + ($this->TCEform->docLarge ? 150 : 0);
./typo3/sysext/rtehtmlarea/Classes/RteHtmlAreaBase.php: $RTEWidth = $RTEWidth + ($this->TCEform->docLarge ? [...]
./typo3/sysext/rtehtmlarea/Classes/RteHtmlAreaBase.php: $RTEHeight = $RTEHeight + ($this->TCEform->docLarge ? [...]

Thanks for attending to this issue. :-)

Actions #3

Updated by Markus Klein over 9 years ago

Hell yeah. Good catch. Thanks a lot. Will do a followup on this.

Actions #4

Updated by Markus Klein over 9 years ago

  • Category set to Backend User Interface
  • Status changed from New to Accepted
  • Assignee set to Markus Klein
  • Target version set to next-patchlevel
  • Complexity set to easy
  • Is Regression changed from No to Yes
Actions #5

Updated by Gerrit Code Review over 9 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30954

Actions #6

Updated by Gerrit Code Review over 9 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31274

Actions #7

Updated by Markus Klein over 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF