Project

General

Profile

Actions

Bug #59938

closed

Empty class selector crashes Update image dialog box

Added by Francois Suter over 9 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Category:
RTE (rtehtmlarea + ckeditor)
Target version:
Start date:
2014-06-27
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.3
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

If the class selector is displayed in the "Update image" dialog box, but that class selector is empty (because no classes are defined), the related JavaScript will crash when trying to determine the selected class. This then prevents the plugin.close() command that comes later to be executed. In turn this causes the dialog to be reloaded instead of being closed eventually leading to an error about the form token being invalid (a symptom which is quite hard to relate to the original cause ;-) ).

A simple test on the number of options in the selector prevents this error.

Actions #1

Updated by Francois Suter over 9 years ago

How to reproduce:

  • make sure that the class selector is enabled for images in the RTE
  • select an image and choose "Modify image"
  • no need to actually change anything, just close on the "Update" button
  • the window does not close and display the security token error.
Actions #2

Updated by Gerrit Code Review over 9 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31169

Actions #3

Updated by Gerrit Code Review over 9 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31350

Actions #4

Updated by Francois Suter over 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #5

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF